VersionChecker Logic is giving false negatives.

[dvantuyl]

Error:

You are using Curb 0.9.10. WebMock is known to work with Curb >= 0.7.16, < 1.1, except versions 0.8.7. It may not work with this version.

Broken Code (github link):

    def compare_version
      case
        when @major < @min_major then :too_low
        when @max_major && @major > @max_major then :too_high
        when @major > @min_major then :ok
        when @minor < @min_minor then :too_low
        when @max_minor && @minor > @max_minor then :too_high
        when @minor > @min_minor then :ok
        when @patch < @min_patch then :too_low
      end
    end

Values Mapped:

@major = 0
@minor = 9
@patch = 10

@min_major = 0
@min_minor = 7
@min_patch = 16

@max_major = 1
@max_minor = 0
@max_patch = 1

Issue:

1. Passes through first :ok since (0 > 0) == false
2. Errors on the second :too_high since (1 && 9 > 0)

[knarewski]

Likely a duplicate of #1006 ?

[dvantuyl]

Yes thank you @knarewski. Closing as duplicate.