-
Notifications
You must be signed in to change notification settings - Fork 466
Comparing changes
Open a pull request
base repository: bazelbuild/rules_rust
base: 0.59.1
head repository: bazelbuild/rules_rust
compare: 0.59.2
- 15 commits
- 278 files changed
- 5 contributors
Commits on Mar 14, 2025
-
Provide an option to opt-out of compile_well_known_types (#3228)
This PR adds a `compile_well_known_types` flag to the Prost toolchain declaration. By default, for backwards compatibility reasons, this flag is set to `True`, as this is the current behavior. If this flag is switched to `False`, the `compile_well_known_types` option is no longer passed to Prost and Tonic, and the protoc wrapper will ignore types from the `google.protobuf` package when computing external types, relying instead on [prost's own externals handling](https://github.com/tokio-rs/prost/blob/e617832ab432adc7dd799321eb216c82a589d421/prost-build/src/extern_paths.rs#L35-L62). Furthermore, the configured Prost types crate will be added as a runtime dependency to all `rust_prost_library` targets. We're currently migrating away from our own set of proto rules to `rust_prost_library`, but our existing code relies heavily on the `prost-types` crate's implementations of well-known-types, which is the recommended way of using prost. However, the current behavior of `rules_rust_prost` makes it impossible to wire up properly, hence this PR. Fixes #2058 --------- Co-authored-by: UebelAndre <github@uebelandre.com>
Configuration menu - View commit details
-
Copy full SHA for 8972781 - Browse repository at this point
Copy the full SHA 8972781View commit details
Commits on Mar 15, 2025
-
Enable pipelined_compilation tests for windows (#3347)
It's not clear why windows is disabled from this. Gonna enable it so developers can give it a try.
Configuration menu - View commit details
-
Copy full SHA for 10c245e - Browse repository at this point
Copy the full SHA 10c245eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fc51c - Browse repository at this point
Copy the full SHA f7fc51cView commit details -
Configuration menu - View commit details
-
Copy full SHA for df45573 - Browse repository at this point
Copy the full SHA df45573View commit details
Commits on Mar 16, 2025
-
@UebelAndre my last MR got in a funky state due to the github rev pin of crates-index. I opted to just redo the MR instead of fighting the rebase.
Configuration menu - View commit details
-
Copy full SHA for 9f0d823 - Browse repository at this point
Copy the full SHA 9f0d823View commit details -
Fix temp value is freed (#3350)
Fixes[ issue](#3349) Tested and verified
Configuration menu - View commit details
-
Copy full SHA for 0fee1ee - Browse repository at this point
Copy the full SHA 0fee1eeView commit details -
Update MSRV in MODULE.bazel as well as WORKSPACE.bazel (#3353)
Since our testing mostly uses bzlmod these days, we've currently regressed in this coverage.
Configuration menu - View commit details
-
Copy full SHA for 5d5286c - Browse repository at this point
Copy the full SHA 5d5286cView commit details
Commits on Mar 17, 2025
-
Updated unit tests for runfiles (#3352)
This introduces a small re-implementation of https://crates.io/crates/temp-env while keeping the tests free of dependencies. This should make it substantially easier to write meaningful tests for runfiles.
Configuration menu - View commit details
-
Copy full SHA for bfb06e6 - Browse repository at this point
Copy the full SHA bfb06e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a0ded8 - Browse repository at this point
Copy the full SHA 5a0ded8View commit details
Commits on Mar 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2f81c8d - Browse repository at this point
Copy the full SHA 2f81c8dView commit details -
Fix rust_bindgen compile flag filtering (#3363)
All flags were treated as accepting a parameter, causing any argument following a parameterless flag (e.g. `-no-standard-includes`) to be passed through. This causes bindgen failures if the next argument isn't supported by clang. `-nostd*` flags has also been expanded using https://clang.llvm.org/docs/ClangCommandLineReference.html to make it clearer that these flags are parameterless. Since these flags resulted in a prefix match, not a full match, they wouldn't set `open_arg = True` and therefore wouldn't cause issues, but this behavior is unnecessarily subtle now that there are two lists. Fixes #3359
Configuration menu - View commit details
-
Copy full SHA for 633e56d - Browse repository at this point
Copy the full SHA 633e56dView commit details
Commits on Mar 19, 2025
-
Configuration menu - View commit details
-
Copy full SHA for d5f8879 - Browse repository at this point
Copy the full SHA d5f8879View commit details -
Configuration menu - View commit details
-
Copy full SHA for da98390 - Browse repository at this point
Copy the full SHA da98390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40648cd - Browse repository at this point
Copy the full SHA 40648cdView commit details
Commits on Mar 20, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 1832faa - Browse repository at this point
Copy the full SHA 1832faaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.59.1...0.59.2