Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/rules_rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.59.1
Choose a base ref
...
head repository: bazelbuild/rules_rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.59.2
Choose a head ref
  • 15 commits
  • 278 files changed
  • 5 contributors

Commits on Mar 14, 2025

  1. Provide an option to opt-out of compile_well_known_types (#3228)

    This PR adds a `compile_well_known_types` flag to the Prost toolchain
    declaration.
    
    By default, for backwards compatibility reasons, this flag is set to
    `True`, as this is the current behavior. If this flag is switched to
    `False`, the `compile_well_known_types` option is no longer passed to
    Prost and Tonic, and the protoc wrapper will ignore types from the
    `google.protobuf` package when computing external types, relying instead
    on [prost's own externals
    handling](https://github.com/tokio-rs/prost/blob/e617832ab432adc7dd799321eb216c82a589d421/prost-build/src/extern_paths.rs#L35-L62).
    Furthermore, the configured Prost types crate will be added as a runtime
    dependency to all `rust_prost_library` targets.
    
    We're currently migrating away from our own set of proto rules to
    `rust_prost_library`, but our existing code relies heavily on the
    `prost-types` crate's implementations of well-known-types, which is the
    recommended way of using prost. However, the current behavior of
    `rules_rust_prost` makes it impossible to wire up properly, hence this
    PR.
    
    Fixes #2058
    
    ---------
    
    Co-authored-by: UebelAndre <github@uebelandre.com>
    alexkirsz and UebelAndre authored Mar 14, 2025
    Copy the full SHA
    8972781 View commit details

Commits on Mar 15, 2025

  1. Enable pipelined_compilation tests for windows (#3347)

    It's not clear why windows is disabled from this. Gonna enable it so
    developers can give it a try.
    UebelAndre authored Mar 15, 2025
    Copy the full SHA
    10c245e View commit details
  2. Fixed warnings in various targets (#3345)

    UebelAndre authored Mar 15, 2025
    Copy the full SHA
    f7fc51c View commit details
  3. Bump crate_universe buildifier version (#3344)

    UebelAndre authored Mar 15, 2025
    Copy the full SHA
    df45573 View commit details

Commits on Mar 16, 2025

  1. Updated crates index (#3351)

    @UebelAndre my last MR got in a funky state due to the github rev pin of
    crates-index. I opted to just redo the MR instead of fighting the
    rebase.
    ericmcbride authored Mar 16, 2025
    Copy the full SHA
    9f0d823 View commit details
  2. Fix temp value is freed (#3350)

    Fixes[ issue](#3349)
    
    Tested and verified
    ericmcbride authored Mar 16, 2025
    Copy the full SHA
    0fee1ee View commit details
  3. Update MSRV in MODULE.bazel as well as WORKSPACE.bazel (#3353)

    Since our testing mostly uses bzlmod these days, we've currently
    regressed in this coverage.
    illicitonion authored Mar 16, 2025
    Copy the full SHA
    5d5286c View commit details

Commits on Mar 17, 2025

  1. Updated unit tests for runfiles (#3352)

    This introduces a small re-implementation of
    https://crates.io/crates/temp-env while keeping the tests free of
    dependencies. This should make it substantially easier to write
    meaningful tests for runfiles.
    UebelAndre authored Mar 17, 2025
    Copy the full SHA
    bfb06e6 View commit details
  2. Enable more tests on Windows (#3348)

    UebelAndre authored Mar 17, 2025
    Copy the full SHA
    5a0ded8 View commit details

Commits on Mar 18, 2025

  1. Updated bindgen to 0.71.1 (#3358)

    UebelAndre authored Mar 18, 2025
    Copy the full SHA
    2f81c8d View commit details
  2. Fix rust_bindgen compile flag filtering (#3363)

    All flags were treated as accepting a parameter, causing any argument
    following a parameterless flag (e.g. `-no-standard-includes`) to be
    passed through. This causes bindgen failures if the next argument isn't
    supported by clang.
    
    `-nostd*` flags has also been expanded using
    https://clang.llvm.org/docs/ClangCommandLineReference.html to make it
    clearer that these flags are parameterless. Since these flags resulted
    in a prefix match, not a full match, they wouldn't set `open_arg = True`
    and therefore wouldn't cause issues, but this behavior is unnecessarily
    subtle now that there are two lists.
    
    Fixes #3359
    bmclarnon authored Mar 18, 2025
    Copy the full SHA
    633e56d View commit details

Commits on Mar 19, 2025

  1. Remove forced debug logs from rust_wasm_bindgen_test (#3355)

    UebelAndre authored Mar 19, 2025
    Copy the full SHA
    d5f8879 View commit details
  2. Added Rust 1.85.1 (#3364)

    UebelAndre authored Mar 19, 2025
    Copy the full SHA
    da98390 View commit details
  3. Avoid direct references to volatile files (#3361)

    closes #3297
    UebelAndre authored Mar 19, 2025
    Copy the full SHA
    40648cd View commit details

Commits on Mar 20, 2025

  1. Release 0.59.2 (#3362)

    UebelAndre authored Mar 20, 2025
    Copy the full SHA
    1832faa View commit details
Loading