Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime env toolchain is missing executable bit #2085

Closed
rickeylev opened this issue Jul 23, 2024 · 0 comments · Fixed by #2086
Closed

runtime env toolchain is missing executable bit #2085

rickeylev opened this issue Jul 23, 2024 · 0 comments · Fixed by #2086

Comments

@rickeylev
Copy link
Collaborator

The //python/runtime_env_toolchains file python/private/runtime_env_toolchain_interpreter.sh is missing the executable bit, which makes Bazel unable to execute the file when it's used.

This basically makes it not work as a runnable toolchain (though it works OK for a toolchain
that just needs to get past the build phase).

To fix, it just needs chmod +x added to it.
@rickeylev rickeylev mentioned this issue Jul 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2024
@rickeylev
fix: add missing +x to runtime env toolchain interpreter script (#2086)
Loading
Loading status checks…
59bb4a8 
The `runtime_env_toolchain_interpreter.sh` file was missing the
executable bit, which prevented the file from actually be runnable
later.

To fix, just `chmod +x` it. I also added tests to actually run using it
and verify that
it is the toolchain used by the test.

Fixes #2085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing +x to runtime env toolchain interpreter script rickeylev/rules_python
1 participant
@rickeylev