Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate logic for collecting js inputs from providers #2667

Closed
alexeagle opened this issue May 11, 2021 · 4 comments
Closed

Consolidate logic for collecting js inputs from providers #2667

alexeagle opened this issue May 11, 2021 · 4 comments
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
6.0

Comments

@alexeagle
Copy link
Collaborator

in 5ad1596 we observed that this logic is inconsistent. We should have a starlark helper function to iterate through the providers on the deps and collect the exposed JS files that can be input for tools
@alexeagle alexeagle added this to the 4.0 milestone May 11, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Aug 10, 2021
@alexeagle alexeagle modified the milestones: 4.0, 5.0 Aug 13, 2021
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

@alexeagle alexeagle removed the Can Close? We will close this in 30 days if there is no further activity label Aug 30, 2021
@alexeagle alexeagle reopened this Aug 30, 2021
@thesayyn thesayyn added cleanup Tech debt, resolving it improves our own velocity package:builtin labels Sep 11, 2021
@alexeagle
Copy link
Collaborator Author

Looks like it's too late for this to make 5.0, slipping...

@alexeagle alexeagle modified the milestones: 5.0, 6.0 Jan 13, 2022
@jbedard jbedard removed their assignment Nov 16, 2022
@gregmagolan
Copy link
Collaborator

No longer in scope for rules_nodejs which only supplies the Node.js toolchain as of v6.0.0.

Downstream canonical JavaScript + Node.js ruleset is now https://github.com/aspect-build/rules_js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
4 participants
@alexeagle @jbedard @gregmagolan @thesayyn