Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow network-related env variables to be removed #2029

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Allow network-related env variables to be removed #2029

merged 2 commits into from
Aug 30, 2024
+6 −5

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Aug 30, 2024

This can be used to e.g. remove JAVA_TOOL_OPTIONS when it interferes with tests.

@fmeum
Allow environment variables to be removed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
cc5f406 
This can be used to e.g. remove `JAVA_TOOL_OPTIONS` when it interferes with tests.
@fmeum fmeum mentioned this pull request Aug 30, 2024
Merged
meteorcloudy
meteorcloudy requested changes Aug 30, 2024
View reviewed changes
buildkite/bazelci.py Outdated
if value is None:
os.environ.pop(key)
else:
os.environ[key] = os.path.expandvars(str(value))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe just moving

continuous-integration/buildkite/bazelci.py

Lines 1239 to 1243 in cc5f406

# Avoid "Network is unreachable" errors in IPv6-only environments
for e in ("COURSIER_OPTS", "JAVA_TOOL_OPTIONS", "SSL_CERT_FILE"):
if os.getenv(e):
test_env_vars.append(e)
after dealing with "environment" could already work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick, updated.

@fmeum
Update bazelci.py
Loading
Loading status checks…
7d1ea2f
@fmeum fmeum changed the title Allow environment variables to be removed Allow network-related env variables to be removed Aug 30, 2024
meteorcloudy
meteorcloudy approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 8b5d8e9 into bazelbuild:master Aug 30, 2024
1 check passed
@fmeum fmeum deleted the patch-2 branch August 30, 2024 12:50
fweikert pushed a commit to fweikert/continuous-integration that referenced this pull request Mar 27, 2025
@fmeum @fweikert
Allow network-related env variables to be removed (bazelbuild#2029)
15484f5 
This can be used to e.g. remove `JAVA_TOOL_OPTIONS` when it interferes
with tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy

@fweikert fweikert

@Wyverald Wyverald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmeum @meteorcloudy