Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image with the latest bats-file version #780

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

hugocf
Copy link
Contributor

@hugocf hugocf commented Aug 28, 2023

See more info in bats-core/bats-file#62 (comment)

@hugocf hugocf requested a review from a team as a code owner August 28, 2023 11:30
@brokenpip3
Copy link
Contributor

@hugocf can you also update the changelog?

@hugocf
Copy link
Contributor Author

hugocf commented Aug 29, 2023

@hugocf can you also update the changelog?

✅ Done (commit 0a712e0)

@hugocf
Copy link
Contributor Author

hugocf commented Sep 18, 2023

Hi @brokenpip3 @bats-core, is there anything holding this PR?

The failed check about Tests / npm_on_windows (windows-2019) (pull_request) seems fortuitous given that it happened on an update to the CHANGELOG.md text file.

Can someone try running the checks again?
What can we do to merge this?

@hugocf
Copy link
Contributor Author

hugocf commented Oct 13, 2023

@brokenpip3 @bats-core can we merge this PR as it is all green?

@brokenpip3
Copy link
Contributor

sorry for the late reply, looks good, however I'm not owner for the bats binary, I can merge it but I prefer to wait from someone from @bats-core/bats-core, sorry.

@martin-schulze-vireso martin-schulze-vireso merged commit f1f5115 into bats-core:master Oct 13, 2023
53 checks passed
@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Oct 13, 2023

Thanks for your contribution. I am sorry for the delay, I don't find enough time for Bats lately.

@marshallford
Copy link

Glad to see this PR accepted. Is there an upcoming release planned that would include this change? Currently I use RUN /tmp/docker/install_libs.sh file 0.4.0 as a workaround. Thanks!

@martin-schulze-vireso
Copy link
Member

I am very time constrained and the current milestone/release is constantly slipping past deadlines. My hopes are on getting some time in during holiday season but I would not bet on it.

@hugocf hugocf deleted the bats-core-patch-docker branch December 22, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants