-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for runtime test for multilib support #487
Conversation
I think the test failure already shows the problem: There are many users who will not run I am unsure how other projects solve this problem but it might be possible to have a configuration file that only stores some variable definitions like bats_libdir and is optional. |
I once thought use a configure file to export such kind of env variable. But I find there is a env var BATS_ROOT exported in bin/bats, so I did the same way. |
The BATS_ROOT is easily determined by the path to the bats binary. However, the libdir is not as easily discovered. Regarding the install on windows: I am not sure if it is even used on this platform. The current install paths don't strike me as windows friendly but I did not try. |
@martin-schulze-vireso I involved a config file and set with the libdir. If the config file does not exist or the env variable does not set , it assumes 'lib'. And I do some work on uninstall.sh. Let's check wether it works. |
4b37c12
to
b78b9de
Compare
Co-authored-by: Kai Kang <kai.kang@windriver.com>
e92e986
to
a401cd8
Compare
150f846
to
08d1521
Compare
Test in a docker with:
1
$ cd /path/to/bats-core
$ ./install.sh /usr/ lib64
$ bats tests
$ ./uninstall.sh /usr/ lib64
2
$ ./install.sh /usr/
$ bats tests
$ ./uninstall.sh /usr/
Both results are as same as before: