Add MethodSource.clear_cache #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We often need to clear cache.
For example, in web application development, when we changed source code, we would like the change applied to the app server without reboot.
In the case of a Rails application, this requires the following configuration:
```ruby
Rails.application.configure do
config.to_prepare do
MethodSource.instance_variable_set(:@lines_for_file, {})
end
end
```
It seems so ugly, isn't it? So I feel we need to add `MethodSource.clear_cache` interface.
```diff
Rails.application.configure do
config.to_prepare do
- MethodSource.instance_variable_set(:@lines_for_file, {})
+ MethodSource.clear_cache
end
end
```
|
LGTM 🚢 |
|
\o/ please release this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often need to clear cache.
For example, in web application development, when we changed source code, we would like the change applied to the app server without reboot.
In the case of a Rails application, this requires the following configuration:
It seems so ugly, isn't it? So I feel we need to add
MethodSource.clear_cacheinterface.Rails.application.configure do config.to_prepare do - MethodSource.instance_variable_set(:@lines_for_file, {}) + MethodSource.clear_cache end end