Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrading bitflags from 1.3 to 2.4 breaks existing code #19

Closed
berlin-with0ut-return opened this issue Sep 13, 2023 · 1 comment
Closed

upgrading bitflags from 1.3 to 2.4 breaks existing code #19

berlin-with0ut-return opened this issue Sep 13, 2023 · 1 comment

Comments

@berlin-with0ut-return
Copy link
Contributor

berlin-with0ut-return commented Sep 13, 2023 •
edited

hi, me again. i noticed that as part of the 0.5.4 release, the bitflags library was updated. the main breaking change with this update is that the Debug, Copy, Clone, Hash, PartialEq, and Eq traits are no longer automatically derived (see this issue ).
our existing code assumes the Clone, Debug, PartialEq, Copy traits for the PacketFlag struct in order to function.

i went ahead and added this as a pull request - let me know if you anticipate any downstream issues with this change.
This was referenced Sep 14, 2023
Closed
Merged
@balliegojr
Copy link
Owner

Hi,

Sorry, I really missed that change when updating the dependencies.

Just published a new version with your fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balliegojr @berlin-with0ut-return