From 2dc6f8d3d6295ec0757c57db6da4b34187db246e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Tue, 4 Jul 2023 14:40:05 -0400 Subject: [PATCH] remove semver dependency --- packages/babel-standalone/package.json | 3 +- .../test/transform-script-tags.test.js | 47 ++++++++++--------- yarn.lock | 1 - 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/packages/babel-standalone/package.json b/packages/babel-standalone/package.json index 80ebd60728db..537745bf648f 100644 --- a/packages/babel-standalone/package.json +++ b/packages/babel-standalone/package.json @@ -113,8 +113,7 @@ "@babel/preset-react": "workspace:^", "@babel/preset-typescript": "workspace:^", "acorn": "^8.7.0", - "jsdom": "^22.1.0", - "semver": "^6.3.0" + "jsdom": "^22.1.0" }, "keywords": [ "babel", diff --git a/packages/babel-standalone/test/transform-script-tags.test.js b/packages/babel-standalone/test/transform-script-tags.test.js index 44113580427a..d93290c11dba 100644 --- a/packages/babel-standalone/test/transform-script-tags.test.js +++ b/packages/babel-standalone/test/transform-script-tags.test.js @@ -1,11 +1,11 @@ import fs from "fs"; import { createRequire } from "module"; -import semver from "semver"; +import { itGte } from "$repo-utils"; const require = createRequire(import.meta.url); -const nodeGte16 = semver.gte(process.version, "16.0.0"); +const nodeGte16 = itGte("16.0.0"); -(nodeGte16 ? describe : describe.skip)("transformScriptTags", () => { +describe("transformScriptTags", () => { let standaloneSource; let JSDOM; beforeAll(async () => { @@ -15,7 +15,7 @@ const nodeGte16 = semver.gte(process.version, "16.0.0"); ); JSDOM = require("jsdom").JSDOM; }); - it("should transform script element with type 'text/babel'", () => { + nodeGte16("should transform script element with type 'text/babel'", () => { const dom = new JSDOM( ``, { runScripts: "dangerously" }, @@ -36,24 +36,27 @@ const nodeGte16 = semver.gte(process.version, "16.0.0"); }); }); }); - it("should pass through the nonce attribute to the transformed script element", () => { - const nonceAttribute = "nonce_example"; + nodeGte16( + "should pass through the nonce attribute to the transformed script element", + () => { + const nonceAttribute = "nonce_example"; - const dom = new JSDOM( - ``, - { runScripts: "dangerously" }, - ); - return new Promise((resolve, reject) => { - dom.window.addEventListener("DOMContentLoaded", () => { - try { - const transformedScriptElement = - dom.window.document.head.children.item(2); - expect(transformedScriptElement.nonce).toBe(nonceAttribute); - resolve(); - } catch (err) { - reject(err); - } + const dom = new JSDOM( + ``, + { runScripts: "dangerously" }, + ); + return new Promise((resolve, reject) => { + dom.window.addEventListener("DOMContentLoaded", () => { + try { + const transformedScriptElement = + dom.window.document.head.children.item(2); + expect(transformedScriptElement.nonce).toBe(nonceAttribute); + resolve(); + } catch (err) { + reject(err); + } + }); }); - }); - }); + }, + ); }); diff --git a/yarn.lock b/yarn.lock index 79676f835809..a319d445c535 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3915,7 +3915,6 @@ __metadata: "@babel/preset-typescript": "workspace:^" acorn: ^8.7.0 jsdom: ^22.1.0 - semver: ^6.3.0 languageName: unknown linkType: soft