Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply fetch latest version from the dedicated file #130

Merged

Conversation

elProxy
Copy link
Contributor

@elProxy elProxy commented Feb 26, 2024

It gets updated as part of the helm release workflow:
https://github.com/helm/helm/blob/c5698e5e51949c4ab86a22c5566fac20e13d6f73/.github/workflows/release.yml#L49

This means the github token is no longer required, making it much nicer
for composite actions wanting to leverage this one.

@elProxy elProxy requested a review from a team as a code owner February 26, 2024 19:21
@elProxy
Copy link
Contributor Author

elProxy commented Feb 26, 2024

@microsoft-github-policy-service agree

@elProxy elProxy force-pushed the dont-require-token-to-fetch-latest-version branch 2 times, most recently from 5fce490 to 59ccd8a Compare February 26, 2024 20:47
It gets updated as part of the helm release workflow:
https://github.com/helm/helm/blob/c5698e5e51949c4ab86a22c5566fac20e13d6f73/.github/workflows/release.yml#L49

This means the github token is no longer required, making it much nicer
for composite actions wanting to leverage this one.
@elProxy elProxy force-pushed the dont-require-token-to-fetch-latest-version branch from 59ccd8a to cb38b0b Compare February 26, 2024 20:48
@elProxy
Copy link
Contributor Author

elProxy commented Feb 27, 2024

@OliverMKing Hi, can you give me a hint as to how often PRs here get looked at ?

Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two small comments. Thank you for this addition! I really like it

action.yml Outdated Show resolved Hide resolved
src/run.test.ts Outdated Show resolved Hide resolved
@elProxy
Copy link
Contributor Author

elProxy commented Feb 29, 2024

left two small comments. Thank you for this addition! I really like it

I like it too. Can't wait to adopt that action in a few places 😉

@elProxy elProxy requested a review from OliverMKing March 1, 2024 07:10
@OliverMKing OliverMKing merged commit ec8dd7c into Azure:main Mar 1, 2024
4 checks passed
@OliverMKing
Copy link
Collaborator

This is available in v4.1.0

@elProxy
Copy link
Contributor Author

elProxy commented Mar 1, 2024

This is available in v4.1.0

Awesome !
Thanks a bunch for the quick reviews and smooth process @OliverMKing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants