Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OS detection and download OS-native archive extension #124

Merged
merged 1 commit into from Apr 12, 2024
Merged

Fix OS detection and download OS-native archive extension #124

merged 1 commit into from Apr 12, 2024

Conversation

bonddim
Copy link
Contributor

@bonddim bonddim commented Feb 9, 2024

  • Switch from os.type() to os.platform()
  • Download tar.gz archives on non-Windows platforms

Fixes #111
Fixes #119

@bonddim bonddim requested a review from a team as a code owner February 9, 2024 08:26
@bonddim
Copy link
Contributor Author

bonddim commented Mar 4, 2024

@OliverMKing , @davidgamero
pls, review

davidgamero
davidgamero approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the improvement!

@bonddim
Copy link
Contributor Author

bonddim commented Mar 14, 2024

@bfoley13 , maybe you can review?

@cheskayang
Copy link

thx for this fix, when do you think this can be merged and released?

@bonddim
Copy link
Contributor Author

bonddim commented Apr 12, 2024

thx for this fix, when do you think this can be merged and released?

idk, it depends on maintainers decision.

@davidgamero davidgamero merged commit 0a0c55a into Azure:main Apr 12, 2024
4 checks passed
@bonddim bonddim deleted the platforms branch April 12, 2024 20:03
@davidgamero
Copy link
Collaborator

releasing in #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamero davidgamero davidgamero approved these changes

@jaiveerk jaiveerk jaiveerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: unzip not available on ARC runners with default image Bug: Amd64 installed instead of arm
4 participants
@bonddim @cheskayang @davidgamero @jaiveerk