Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #124

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Update README.md #124

merged 7 commits into from
Dec 8, 2023

Conversation

MoChilia
Copy link
Member

@MoChilia MoChilia commented Dec 5, 2023

#57 changed the default value for azcliversion from latest to the version of Azure CLI installed on agent. If there is no version of Azure CLI found on the agent, the action falls back the version to latest.

cli/src/main.ts

Lines 32 to 44 in bb23033

if (azcliversion == AZ_CLI_VERSION_DEFAULT_VALUE) {
try {
const { stdout, stderr } = await cpExec('az version');
if (!stderr) {
azcliversion = JSON.parse(stdout)["azure-cli"]
} else {
throw stderr
}
} catch (err) {
console.log('Failed to fetch az cli version from agent. Reverting back to latest.')
azcliversion = 'latest'
}
}

This pr will update the description about default version used in azure/cli and remove the 'Configure Azure credentials as GitHub Secret' section, since it is not related to azure/cli action, but should be found in https://github.com/Azure/login/blob/master/README.md. And 'Azure CLI Action metadata file' section will be removed, since it is unnecessary to appear in README.md.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MoChilia MoChilia requested review from YanaXu and jiasli December 5, 2023 05:12
@MoChilia MoChilia requested a review from jiasli December 5, 2023 08:05
@MoChilia MoChilia merged commit 7890b57 into Azure:master Dec 8, 2023
@MoChilia MoChilia deleted the modify-readme branch December 8, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants