Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ClientCore's baseline to Java 8 and make it a multi-release JAR #43931

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jan 24, 2025

Description

Reverts the baseline of ClientCore, and downstream libraries, back to Java 8 from Java 17. This PR does not add back http-jdk-httpclient and instead moves that code added to ClientCore into a multi-release JAR folder. With this change, by default, there will be NO HttpClient instance on the classpath or available when running with Java 8 to Java 11, only Java 12 and beyond will have a default HttpClient available. For anyone using Java 8 - 11 they MUST include one of the HttpClient implementation packages to allow their application to work. Additionally, when creating an uber JAR with ClientCore you MUST enable it to be a multi-release JAR otherwise the application WON'T have an HttpClient available by default unless another one is included in the uber JAR.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
hirotasoshu Maksim Zayakin
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:core

@alzimmermsft alzimmermsft marked this pull request as ready for review January 24, 2025 18:31
@alzimmermsft alzimmermsft merged commit 4bd28aa into Azure:main Jan 24, 2025
21 checks passed
@alzimmermsft alzimmermsft deleted the AzCC_Java8BaselineAndMultiReleaseJar branch January 24, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants