Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module generation import fix #9

Merged
merged 1 commit into from Dec 22, 2021

Conversation

kaleidawave
Copy link
Contributor

Hey, made a little mistake in #7. If generating variants into a module with #[evt(module = "module1")] then the module only imported the enum declaration not any types, traits or proc derive macros. This means output wouldn't compile if the structure had non prelude types in fields or used non prelude marker traits or proc derive macros. This PR fixes that by importing everything from the parent scope with use super::*;

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #9 (74f873f) into master (63fc9d0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files           2        2           
  Lines         163      163           
=======================================
  Hits          115      115           
  Misses         48       48           
Impacted Files Coverage Δ
src/lib.rs 66.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fc9d0...74f873f. Read the comment docs.

@azriel91 azriel91 merged commit ba32d58 into azriel91:master Dec 22, 2021
@azriel91
Copy link
Owner

heya, gotcha. only really discover things when one uses it ey ✌️

@azriel91
Copy link
Owner

Released in 0.3.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants