Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The section Developing in CONTRIBUTING file confusing #5969

Closed
MrJithil opened this issue Oct 4, 2023 · 4 comments · Fixed by #6073 · May be fixed by #5970
Closed

The section Developing in CONTRIBUTING file confusing #5969

MrJithil opened this issue Oct 4, 2023 · 4 comments · Fixed by #6073 · May be fixed by #5970

Comments

@MrJithil
Copy link

MrJithil commented Oct 4, 2023 •
edited

Section/Content To Improve

The section developing mentioning about the below 3 commands

  • grunt test run the jasmine and mocha tests
  • grunt build run webpack and bundle the source
  • grunt version prepare the code for release

But, the package json defines scripts for the same which is using npm.

Or are we still using grunt?

Suggested Improvement

  • npm run test the jasmine and mocha tests
  • npm run build webpack and bundle the source
  • npm run version prepare the code for release

Relevant File(s)

https://github.com/axios/axios/blob/v1.x/CONTRIBUTING.md#developing
@TheShiveshNetwork
Copy link

Hello, I am working on this issue, will get back to you soon!

@TheShiveshNetwork TheShiveshNetwork mentioned this issue Oct 4, 2023
Open
@Vansh1419
Copy link

Could u assign this issue to me?

@MrJithil
Copy link
Author

MrJithil commented Oct 5, 2023

Could u assign this issue to me?

PR already raised.

@ckng0221 ckng0221 mentioned this issue Nov 11, 2023
Merged
@ckng0221
Copy link
Contributor

To take note grunt is also present in the examples/README.md file.
#6073 will change the grunt in the README file to npm run too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@MrJithil @ckng0221 @TheShiveshNetwork @Vansh1419