Axios response headers may be undefined
#4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gprst
force-pushed
the
fix/axios-response-headers-typing
branch
2 times, most recently
from
c5b19b1
to
0c338d9
Compare
gprst
force-pushed
the
fix/axios-response-headers-typing
branch
from
a0c67f4
to
4b7a2a7
Compare
jasonsaayman
changed the title
undefinedundefined
phloose
pushed a commit
to phloose/axios
that referenced
this pull request
Sep 13, 2022
Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the
AxiosResponseHeaderstype on thev0.xbranch, that currently does not reflect the fact that response headers can beundefined. This seems to be already fixed in theRawAxiosResponseHeaderstype on thev1.xbranch.Fixes #4812