Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create trivial access to request IDs for all SDK responses #76

Closed
2 tasks done
Tracked by #1692
rcoh opened this issue Dec 9, 2020 · 1 comment
Closed
2 tasks done
Tracked by #1692

Create trivial access to request IDs for all SDK responses #76

rcoh opened this issue Dec 9, 2020 · 1 comment
Assignees
@jdisanti
Labels
design pending-release production-readiness sdk sdk-ga
Milestone
SDK GA

Comments

@rcoh
Copy link
Collaborator

rcoh commented Dec 9, 2020 •
edited by jdisanti

Request ids are returned in different locations in each protocol (eg. headers, JSON body, XML body etc.).

As an end customer, it should be straightforward to extract that request id from any given response.

  • Make it trivial to access the request ID programmatically
  • Add a tracing::debug! or tracing::debug_span! somewhere in the AWS middleware to attach the request ID to logs
@rcoh rcoh modified the milestones: Dynamo DB MVP, 1.0 Dec 9, 2020
@rcoh rcoh changed the title Capture request_id in all errors Capture request_id in all requests Jan 13, 2021
@rcoh rcoh changed the title Capture request_id in all requests Capture request_id in all responses Jan 13, 2021
@rcoh rcoh modified the milestones: 1.0, Cross Protocol Functionality Jan 13, 2021
@rcoh rcoh added the large label Jan 13, 2021
@rcoh rcoh changed the title Capture request_id in all responses Design request id cross protocol support Jan 13, 2021
This was referenced Jan 13, 2021
Closed
Closed
@rcoh rcoh removed this from the Cross Protocol Functionality milestone Sep 27, 2021
@jdisanti jdisanti added this to the SDK GA milestone Sep 30, 2022
@jdisanti jdisanti added the sdk label Sep 30, 2022
@jdisanti jdisanti changed the title Design request id cross protocol support Create trivial access to request IDs for all SDK responses Sep 30, 2022
@jdisanti jdisanti added design and removed large labels Sep 30, 2022
@jdisanti jdisanti mentioned this issue Dec 7, 2022
Merged
2 tasks
@jdisanti jdisanti mentioned this issue Dec 7, 2022
Closed
28 tasks
@jdisanti jdisanti self-assigned this Dec 8, 2022
@jdisanti
Copy link
Collaborator

jdisanti commented Dec 9, 2022

RFC: #2083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisanti jdisanti

Labels
design pending-release production-readiness sdk sdk-ga
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
3 participants
@jdisanti @rcoh @ysaito1001