Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bedrock): create index with faiss and l2 #350

Merged
merged 1 commit into from Apr 1, 2024

Conversation

jl4nz
Copy link
Contributor

@jl4nz jl4nz commented Apr 1, 2024

Fixes #349

New KB bedrock indexes use faiss.

CDK:
KnowledgeBase/KB: Received response status [FAILED] from custom resource. Message returned: Error: An error occurred (ValidationException) when calling the CreateKnowledgeBase operation: The knowledge base storage configuration provided is invalid... The OpenSearch Serverless engine type associated with your vector index is invalid. Recreate your vector index with one of the following valid engine types: FAISS. Then retry your request.

New setup from AWS Console
Screenshot 2024-04-01 at 16 09 39

@jstrunk
Copy link
Contributor

jstrunk commented Apr 1, 2024

Thank you for catching this and submitting this PR. I confirmed in the Bedrock KB docs that OpenSearch indexes should now be faiss to support the new metadata filtering feature. The l2 space type refers to Euclidean Distance which is the new recommendation.

@krokoko krokoko enabled auto-merge (squash) April 1, 2024 12:37
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (dafcdc0) to head (d6b2bf5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   96.13%   96.35%   +0.21%     
==========================================
  Files          40       40              
  Lines        9682     9682              
  Branches      277      279       +2     
==========================================
+ Hits         9308     9329      +21     
+ Misses        374      353      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krokoko krokoko merged commit 529fbc5 into awslabs:main Apr 1, 2024
22 of 25 checks passed
@krokoko
Copy link
Collaborator

krokoko commented Apr 1, 2024

thanks @jl4nz for this contribution ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(generative-ai-cdk-constructs): KnowledgeBase construct cannot create vector store
5 participants