Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qa): read properly var to fix streaming #341

Merged
merged 1 commit into from Mar 26, 2024

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Mar 25, 2024

Fixes #

  • Fix issue where streaming is not working properly: variable for streaming was not read correctly
  • test with both streaming enabled and disable for several models
  • update documentation to include that streaming is supported for qa

Example:
Test streaming enabled with claude 3 - rag approach. Callback on new llm token correctly called and response generated
Screenshot 2024-03-25 at 5 29 50 PM


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (b4584f0) to head (f3cf4af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   96.35%   96.13%   -0.22%     
==========================================
  Files          40       40              
  Lines        9682     9682              
  Branches      279      277       -2     
==========================================
- Hits         9329     9308      -21     
- Misses        353      374      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krokoko krokoko merged commit e58f614 into awslabs:main Mar 26, 2024
21 of 22 checks passed
@krokoko krokoko deleted the streaming_fix branch April 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants