Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): fixed bugs in image generation construct #338

Merged
merged 11 commits into from Mar 22, 2024

Conversation

dineshSajwan
Copy link
Contributor

@dineshSajwan dineshSajwan commented Mar 22, 2024

Fixes #

  1. updated image generation construct with comprehend and s3 actions
  2. updated image generation construct with GraphQL api type
  3. Updated template description format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@dineshSajwan dineshSajwan requested a review from a team as a code owner March 22, 2024 14:13
@dineshSajwan dineshSajwan changed the title Feature/defect fixes feat(construct): fixed bugs in image generation construct Mar 22, 2024
dineshSajwan and others added 2 commits March 22, 2024 10:15
Signed-off-by: github-actions <github-actions@github.com>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (4d16b8a) to head (95da8e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   96.13%   96.13%   -0.01%     
==========================================
  Files          40       40              
  Lines        9688     9682       -6     
  Branches      279      277       -2     
==========================================
- Hits         9314     9308       -6     
  Misses        374      374              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krokoko
krokoko previously approved these changes Mar 22, 2024
@krokoko krokoko enabled auto-merge (squash) March 22, 2024 15:02
krokoko
krokoko previously approved these changes Mar 22, 2024
Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Signed-off-by: Dinesh Sajwan <sajwandinesh03@gmail.com>
dineshSajwan and others added 3 commits March 22, 2024 18:22
Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Signed-off-by: Dinesh Sajwan <sajwandinesh03@gmail.com>
Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Signed-off-by: Dinesh Sajwan <sajwandinesh03@gmail.com>
Signed-off-by: github-actions <github-actions@github.com>
@krokoko krokoko self-requested a review March 22, 2024 22:31
@krokoko krokoko merged commit 24d63a3 into main Mar 22, 2024
17 of 18 checks passed
@krokoko krokoko deleted the feature/defect_fixes branch March 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants