Shared Subscription tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfred2g
force-pushed
the
test_shared_subscription
branch
from
818373f
to
9fe329f
Compare
sbSteveK
reviewed
Jan 9, 2024
test/test_mqtt5.py
Outdated
| @@ -171,7 +172,6 @@ def test_client_creation_maximum(self): | |||
| receive_maximum=1000, | |||
| maximum_packet_size=10000, | |||
| will_delay_interval_sec=1000, | |||
| will=publish_packet, | |||
There was a problem hiding this comment.
Why was this removed? This test is attempting a creation with everything that can possibly be set including the will.
sbSteveK
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared Subscription tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.