Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support request level part size configuration #539

Merged
merged 11 commits into from
Dec 28, 2023
Merged

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Dec 13, 2023

  • Add support for request level override for part size and upload threshold
  • Add support for on_done callback with the did_validate checksum and the checksum algorithm.
  • Submodules update for several S3 related improvements:
    • Fix Get-Object with partNumber
    • Skip HeaderRequest for ranged get
    • Cancel/Pause s3 request now faster (will cancel the ongoing HTTP requests now)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

test/test_s3.py Outdated Show resolved Hide resolved
test/test_s3.py Outdated Show resolved Hide resolved
awscrt/s3.py Show resolved Hide resolved
awscrt/s3.py Outdated Show resolved Hide resolved
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

awscrt/s3.py Show resolved Hide resolved
test/test_s3.py Outdated Show resolved Hide resolved
test/test_s3.py Outdated Show resolved Hide resolved
@TingDaoK TingDaoK merged commit f4a52c8 into main Dec 28, 2023
64 checks passed
@TingDaoK TingDaoK deleted the request-partsize branch December 28, 2023 23:49
graebm added a commit that referenced this pull request Dec 30, 2023
  -  Add support for request level override for part size and upload threshold
  -  Add support for on_done callback with the did_validate checksum and the checksum algorithm.
  -  Submodules update for several S3 related improvements:
       - Fix Get-Object with partNumber
       - Skip HeaderRequest for ranged get
       - Cancel/Pause s3 request now faster (will cancel the ongoing HTTP requests now)


Co-authored-by: Michael Graeb <graebm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants