Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for ecr spec fallbacks for jumpstart models #4943

Conversation

evakravi
Copy link
Member

@evakravi evakravi commented Nov 29, 2024

Issue #, if available:

Description of changes:
JumpStart metadata contains a legacy field called hosting_ecr_specs (and training_ecr_specs) which looks like this:

"hosting_ecr_specs": {
    "framework": "pytorch",
    "framework_version": "1.10.0",
    "py_version": "py38"
}

Using this metadata to resolve image uris for JumpStart models can cause invalid image uris to return, as we no longer rely on these fields for image uris.

Testing done:
Unit + integ tests pass

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@evakravi evakravi requested a review from a team as a code owner November 29, 2024 21:51
if key in {"version", "framework", "container_version", "py_version"}
and value is not None
}:
JUMPSTART_LOGGER.info(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - I would vote for a warning but your call :)

technically, this is still backward incompatible, but the risk of breaking any customers is really low (it would require cx to have written code than calls the retrieve method w/ both a model_id and a framework, container_version and/or py_version which is unlikely.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking of warning but thought it might spam the logs.

i don't see how we can make this not backwards. we can no longer rely on ecr specs for raising exceptions.

patched_validate_model_id_and_get_type.return_value = JumpStartModelType.OPEN_WEIGHTS

region = "us-west-2"
mock_client = boto3.client("s3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: that's not a mock, is it?

…-for-jumpstart-models
…-for-jumpstart-models
…-for-jumpstart-models
@nargokul nargokul merged commit 1326608 into aws:master Dec 12, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants