-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove support for ecr spec fallbacks for jumpstart models #4943
chore: remove support for ecr spec fallbacks for jumpstart models #4943
Conversation
if key in {"version", "framework", "container_version", "py_version"} | ||
and value is not None | ||
}: | ||
JUMPSTART_LOGGER.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - I would vote for a warning
but your call :)
technically, this is still backward incompatible, but the risk of breaking any customers is really low (it would require cx to have written code than calls the retrieve
method w/ both a model_id
and a framework
, container_version
and/or py_version
which is unlikely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was thinking of warning but thought it might spam the logs.
i don't see how we can make this not backwards. we can no longer rely on ecr specs for raising exceptions.
patched_validate_model_id_and_get_type.return_value = JumpStartModelType.OPEN_WEIGHTS | ||
|
||
region = "us-west-2" | ||
mock_client = boto3.client("s3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: that's not a mock, is it?
…-for-jumpstart-models
…-for-jumpstart-models
…-for-jumpstart-models
Issue #, if available:
Description of changes:
JumpStart metadata contains a legacy field called
hosting_ecr_specs
(andtraining_ecr_specs
) which looks like this:Using this metadata to resolve image uris for JumpStart models can cause invalid image uris to return, as we no longer rely on these fields for image uris.
Testing done:
Unit + integ tests pass
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.