-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s2n-quic): expose configuration options for congestion control #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
changed the title
Ak initcwnd
feat(s2n-quic): expose configuration options for congestion control
May 31, 2024
toidiu
force-pushed
the
ak-initcwnd
branch
3 times, most recently
from
June 3, 2024 01:25
e8eae14
to
15f5f0a
Compare
|
||
#[cfg(feature = "unstable-congestion-controller")] | ||
/// The dynamic gain factor used to scale the estimated BDP to produce a | ||
/// congestion window (default: 2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for putting the default values!
WesleyRosenblum
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR exposes a few configuration options that modify the default congestion controllers.
While it is possible to create a custom congestion controller, customers might find it more useful to simply override some key parameters on the deafult congestion controller algorithm rather than replicating the entire congestion control algorithm.
Call out:
with_congestion_window
API is exposed as a stable API, while other options are marked as unstableTesting:
The new options should not affect the default values and therefore existing tests should continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.