ci: fix docker builds #1974
Merged
ci: fix docker builds #1974
+255
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/docker-fixes
branch
3 times, most recently
from
d37aa4d to
b4b5b89
Compare
camshaft
force-pushed
the
camshaft/docker-fixes
branch
from
b4b5b89 to
a8610d3
Compare
toidiu
reviewed
Sep 25, 2023
Comment on lines
+75
to
+81
| RUN set -eux; \ | ||
| apt-get update; \ | ||
| apt-get install -y wget net-tools iputils-ping tcpdump ethtool iperf3 iproute2; \ | ||
| wget https://raw.githubusercontent.com/marten-seemann/quic-network-simulator/${sim_hash}/endpoint/setup.sh; \ | ||
| chmod +x setup.sh; \ | ||
| wget https://raw.githubusercontent.com/vishnubob/wait-for-it/master/wait-for-it.sh; \ | ||
| chmod +x wait-for-it.sh; |
There was a problem hiding this comment.
I think this is fine but I'll mention it. Seems like these files are pretty stable (last edited 3 yrs ago). We could avoid a download here by keeping a local copy if we wanted to in the future.
There was a problem hiding this comment.
I think it would be nicer to figure out docker layer caching and then we can skip building this whole layer entirely since we have a network to deal with anyway with apt-get install.
toidiu
approved these changes
Sep 25, 2023
|
I want to ensure this platform isn't interfering with my device network. Can you please extend my range, and allow my private network to operate. I don't appreciate not receiving my messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #1969
Description of changes:
I ended up inlining the
quic-network-simulator-endpointdocker image, since it's only a few lines long.I've also cleaned up a few things here and there for the qns CI.
Testing:
The qns and release CIs completely pass now!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.