Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): use @smithy types and protocol-http #4722

Merged
merged 3 commits into from May 16, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented May 12, 2023

Issue

Issue number, if available, prefixed with "#"

Description

This PR updates the codegen to use the @smithy/types and @smithy/protocol-http. The latter replaces the @aws-sdk/protocol-http package after its migration to the smithy-typescript repository.

The codegen for clients is included.

Testing

After updating codegen, published smithy-typescript changes locally and ran yarn generate-clients && yarn to update yarn lock file, and tested with yarn test:server-protocols && yarn test:protocols.

Additional context

This change pairs with smithy-lang/smithy-typescript#766.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from a team as a code owner May 12, 2023 22:32
@srchase srchase changed the title Use smithy types protocol http Use @smithy types and protocol-http May 12, 2023
@srchase srchase force-pushed the use-smithy-types-protocol-http branch from a910be7 to 8b16343 Compare May 16, 2023 20:47
@trivikr
Copy link
Member

trivikr commented May 16, 2023

Build failure:

lerna ERR! yarn run build exited 1 in '@aws-sdk/client-lex-runtime-v2'
lerna ERR! yarn run build stdout:
$ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
[build:types] $ tsc -p tsconfig.types.json
[build:cjs] $ tsc -p tsconfig.cjs.json
[build:es] $ tsc -p tsconfig.es.json
[build:types] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:types] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:types] error Command failed with exit code 1.
[build:types] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:types] yarn run build:types exited with code 1
[build:cjs] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:cjs] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:cjs] error Command failed with exit code 2.
[build:cjs] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:cjs] yarn run build:cjs exited with code 2
[build:es] src/protocols/Aws_restJson1.ts(20,19): error TS2300: Duplicate identifier '__SerdeContext'.
[build:es] src/protocols/Aws_restJson1.ts(23,50): error TS2300: Duplicate identifier '__SerdeContext'.
[build:es] error Command failed with exit code 2.
[build:es] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:es] yarn run build:es exited with code 2
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build stderr:
error Command failed with exit code 1.
lerna ERR! yarn run build exited 1 in '@aws-sdk/client-lex-runtime-v2'
lerna WARN complete Waiting for 72 child processes to exit. CTRL-C to exit immediately.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@trivikr trivikr marked this pull request as draft May 16, 2023 21:35
@trivikr trivikr changed the title Use @smithy types and protocol-http feat(deps): use @smithy types and protocol-http May 16, 2023
@srchase
Copy link
Contributor Author

srchase commented May 16, 2023

Fix for the EventStream __SerdeContext import: smithy-lang/smithy-typescript#769

Successful build of EventStream client:

lerna info run Ran npm script 'build' in '@aws-sdk/client-lex-runtime-v2' in 4.5s:
$ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
[build:types] $ tsc -p tsconfig.types.json
[build:es] $ tsc -p tsconfig.es.json
[build:cjs] $ tsc -p tsconfig.cjs.json
[build:es] yarn run build:es exited with code 0
[build:cjs] yarn run build:cjs exited with code 0
[build:types] yarn run build:types exited with code 0
lerna success run Ran npm script 'build' in 66 packages in 162.0s:
lerna success - @aws-sdk/client-lex-runtime-v2

@srchase srchase marked this pull request as ready for review May 16, 2023 22:35
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants