Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK v3 no retry on connection issue #4666

Closed
3 tasks done
wanching0730 opened this issue Apr 26, 2023 · 5 comments
Closed
3 tasks done

AWS SDK v3 no retry on connection issue #4666

wanching0730 opened this issue Apr 26, 2023 · 5 comments
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@wanching0730
Copy link

wanching0730 commented Apr 26, 2023

Checkboxes for prior research

Describe the bug

The connectTimeout attribute in v2 no longer supported in v3, there is no way to set connection timeout value. The default connection timeout is 120s which is too long and it's more than the Lambda timeout that we set. Kindly assist.

SDK version number

@aws-sdk/client-lambda@3.289.0, @aws-sdk/client-dynamodb@3.128.0, @aws-sdk/client-s3@3.289.0, @aws-sdk/client-secrets-manager@3.289.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

node v18.15.0

Reproduction Steps

const requestHandler = new NodeHttpHandler({
  requestTimeout: 1500,
});
const secretManager = new SecretsManagerClient({
  endpoint: SECRETS_MANAGER_VPCE,
  requestHandler,
  maxAttempts: 3,
  region: 'ap-southeast-1'
});

return await secretManager.send(new GetSecretValueCommand({ SecretId: secretName }));

Observed Behavior

timeout

Expected Behavior

There should be a way to set connection timeout in v3, which is the replace the connectTimeout in HttpOptions in v2.

Possible Solution

No response

Additional Information/Context

No response

@wanching0730 wanching0730 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2023
@RanVaknin RanVaknin self-assigned this Apr 26, 2023
@RanVaknin
Copy link
Contributor

Hi @wanching0730 ,
We are working on un-deprecating connectionTimeout. Can you please an older version of the SDK in the meantime while we work to re-introduce this config option?

Thank you very much,
Ran~

@RanVaknin RanVaknin added needs-review This issue/pr needs review from an internal developer. p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2023
@trivikr
Copy link
Member

trivikr commented Apr 26, 2023

The fix to undeprecate connectionTimeout and reintroduce functionality was pushed in PR #4669
It'll be released with v3.322.0 around 1pm Pacific either on Thu 04/27 or Fri 04/28

In the meantime, please use <= v3.295.0 as a workaround.

@RanVaknin RanVaknin added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-review This issue/pr needs review from an internal developer. labels Apr 26, 2023
@wanching0730
Copy link
Author

Noted on that, thank you very much

@trivikr
Copy link
Member

trivikr commented Apr 27, 2023

The fix was released in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.321.1

@trivikr trivikr closed this as completed Apr 27, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p1 This is a high priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

3 participants