Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify resolving sso credential logic #4917

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Modify resolving sso credential logic #4917

merged 8 commits into from
Jul 27, 2023

Conversation

wty-Bryant
Copy link
Contributor

@wty-Bryant wty-Bryant commented Jul 19, 2023

Modify resolving sso credential logic to fix stack overflow bug while configuring shared config profile via env var. Resolves #4912 . The manual test of fixed sso credential resolve logic follows steps below:

  1. run the sso login flow with the AWS CLI
  2. set env variable AWS_SDK_LOAD_CONFIG=TRUE
  3. set env variable AWS_PROFILE=<some_profile_in_config_using_same_sso>
  4. create session with session.NewSession(), then use new session to create S3 client
  5. use the access token generated, call S3 List Buckets on the configured AWS account
  6. when the access token expires, re-call S3 List buckets and see it succeed with an updated expiration in the SSO cached token

@wty-Bryant wty-Bryant marked this pull request as ready for review July 19, 2023 17:15
@wty-Bryant wty-Bryant merged commit 1b1dc9b into main Jul 27, 2023
62 checks passed
@wty-Bryant wty-Bryant deleted the feat-sso-debug branch July 27, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using SSO (AWS Identity Center), AWS_SDK_LOAD_CONFIG=TRUE and session.NewSession() causes stack to overflow
3 participants