Add support for SourceIdentity to stscreds.NewCredentials #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for exposing SourceIdentity on the `AssumeRoleProvider` class. This is a very small commit and just passes through the params. Fixes aws#4829
addisonj
commented
May 9, 2023
| @@ -9,7 +9,7 @@ to refresh the credentials will be synchronized. But, the SDK is unable to | |||
| ensure synchronous usage of the AssumeRoleProvider if the value is shared | |||
| between multiple Credentials, Sessions or service clients. | |||
|
|
|||
| Assume Role | |||
| # Assume Role | |||
There was a problem hiding this comment.
This seem to be getting added by gofmt? I am not sure why these wouldn't already be present, but I did confirm that gofmt wants to add these now
aajtodd
approved these changes
May 9, 2023
isaiahvita
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for exposing SourceIdentity on the
AssumeRoleProviderclass.This is a very small commit and just passes through the params.
Fixes #4829