Fix SDK's EndpointDiscovery and S3 Upload Manager unstable tests #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the EndpointDiscovery mock client's test to consistently pass. The previous test would periodically fail based on timing.
jasdel
force-pushed
the
fixup/EndpointDescTest
branch
from
84da662
to
0a25838
Compare
jasdel
changed the title
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Dec 3, 2018
Fixes the S3 Upload Manager's unstable EOF detection test. Related aws/aws-sdk-go#2286, aws#240
diehlaws
added
needs-review
lucix-aws
added a commit
that referenced
this pull request
Sep 20, 2023
lucix-aws
added a commit
that referenced
this pull request
Sep 21, 2023
lucix-aws
added a commit
that referenced
this pull request
Sep 21, 2023
backport aws-sdk-go-v2/#2286 to v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EndpointDiscovery mock client's test to consistently pass. The
previous test would periodically fail based on timing.
Fixes S3 Upload Manager's unstable unexpected EOF test to be stable.