fix: panic due to potentially uncomparable wrapped fn in express_resolve #2500
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahvita
approved these changes
Feb 15, 2024
wty-Bryant
approved these changes
Feb 15, 2024
lucix-aws
force-pushed
the
fix-expressresolvepanic
branch
from
a496bdd
to
6538eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3 express changes introduced an interface comparison of
CredentialProviders, which is liable to fail on aliased functions that implement that interface (we ourselves expose an alias for this inaws.CredentialsProviderFunc).I've removed the comparison that guards the express provider cloning entirely. It's ultimately not an expensive copy since the underlying session credential cache is shared.
Closes #2473.