Sync models to pull in all OOB endpoints changes #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Sep 15, 2023
isaiahvita
force-pushed
the
sync-models
branch
from
b74334a
to
ebc4720
Compare
isaiahvita
commented
Sep 15, 2023
| @@ -72,7 +72,7 @@ type ListDatasetsInput struct { | |||
| IdentityPoolId *string | |||
|
|
|||
| // The maximum number of results to be returned. | |||
| MaxResults int32 | |||
| MaxResults *int32 | |||
There was a problem hiding this comment.
idk why things like this are here. this is breaking. lets discuss this on monday
There was a problem hiding this comment.
These were expected for cognito-sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfills request to sync all endpoints changes in all service models. This PR includes all model updates, and all regenerated changes. Specifically these changes add smaller rulesets, removed non-unique regional endpoints, fixes FIPS and DualStack endpoints, and make region not required in SDK::Endpoint.
Additional breakfix to cognito-sync field.
Steps performed:
make sync-modelsmake generatemake unitmake integrationall steps above succeeded without error