Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STS PresignAssumeRole support #1787

Closed
1 of 2 tasks
craigfe opened this issue Aug 4, 2022 · 3 comments
Closed
1 of 2 tasks

STS PresignAssumeRole support #1787

craigfe opened this issue Aug 4, 2022 · 3 comments
Assignees
Labels
feature-request A feature should be added or improved. m Effort estimation: medium p3 This is a minor priority issue

Comments

@craigfe
Copy link

craigfe commented Aug 4, 2022

Describe the feature

It'd be great to have support for pre-signing an STS AssumeRole request via the SDK. This was previously possible in SDKv1 by using the standard Presign function, but (as far as I can see) cannot currently be achieved with SDKv2.

I can submit a PR containing this feature if considered worthwhile.

Use Case

We have an internal use-case requiring a Go client to submit a presigned AssumeRole request to a server.

Proposed Solution

The sts.PresignClient currently supports PresignGetCallerIdentity, so this would involve adding a second PresignAssumeRole function in the same place.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2/service/sts@v1.16.7 github.com/aws/aws-sdk-go-v2@v1.16.5

Go version used

1.18.4

@craigfe craigfe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 4, 2022
@RanVaknin RanVaknin self-assigned this Aug 22, 2022
@RanVaknin
Copy link
Contributor

Hi @craigfe ,

Thanks for bringing this to our attention. I've added this to our backlog and will let you know when we add this feature.

Thanks,
Ran~

@RanVaknin RanVaknin removed the needs-triage This issue or PR still needs to be triaged. label Aug 22, 2022
@isaiahvita isaiahvita self-assigned this Oct 17, 2022
@RanVaknin RanVaknin added p3 This is a minor priority issue m Effort estimation: medium labels Nov 14, 2022
@isaiahvita
Copy link
Contributor

closing this issue as it has been fixed by
#1888

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. m Effort estimation: medium p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants