Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[479] CloudWatchEvent renamed to EventBridgeEvent #537

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

mateusmarquezini
Copy link
Contributor

Issue #479

Description of changes:

Hi there! This should fix #479. Please, let me know if you meant something else!

Besides having renamed from CloudWatchEvent to EventBridgeEvent on some places of the code base, I also updated some links (despite they're still redirecting correctly)

Looking forward to your feedback! Thanks! :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f079271) 72.93% compared to head (7d417dd) 72.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          26       26           
  Lines        1456     1456           
=======================================
  Hits         1062     1062           
  Misses        322      322           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmoffatt bmoffatt added type/ux type/events issue or feature request related to the events package documentation labels Dec 19, 2023
events/cloudwatch_events.go Outdated Show resolved Hide resolved
events/cloudwatch_logs.go Outdated Show resolved Hide resolved
events/codepipeline_cloudwatch.go Outdated Show resolved Hide resolved
events/codepipeline_cloudwatch.go Outdated Show resolved Hide resolved
@mateusmarquezini
Copy link
Contributor Author

Thank you for taking the time to suggest improvements @bmoffatt! I just made some changes as you suggested. Now it is as it should I guess. Let me know if it still needs more changes.

events/cloudwatch_events.go Outdated Show resolved Hide resolved
events/README_CloudWatch_Events.md Show resolved Hide resolved
events/cloudwatch_logs_test.go Outdated Show resolved Hide resolved
@bmoffatt bmoffatt merged commit 50dbfb1 into aws:main Jan 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation type/events issue or feature request related to the events package type/ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatchEvent should be renamed
3 participants