-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add omitempty
to ALBTargetGroupRequest.Body
#408
Conversation
If a lambda returns `Body: nil`, then the ALB returns a 502.
Verified that ALB does as you say, 502 returned with json So... I think it's OK to represent in this model that |
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 19 19
Lines 1040 1040
=======================================
Hits 745 745
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
I was referencing this issue recently in a discussion, and realized that the change modified the request, not the response - so the issue described of a 5xx on the response path still exists. |
🤦 You're right. |
This reverts commit 14da40f.
If a lambda returns
Body: nil
, then the ALB returns a 502.