Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler-targets-alpha): rename KinesisDataFirehosePutRecord to FirehosePutRecord #33758

Merged
merged 8 commits into from
Mar 18, 2025

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 13, 2025

Issue # (if applicable)

Related to #33757 and #33798

Reason for this change

Kinesis Data Firehose is now Amazon Data Firehose.
Therefore the class KinesisDataFirehosePutRecord should not be called Kinesis.

Description of changes

  • Renamed KinesisDataFirehosePutRecord to FirehosePutRecord
  • Updated related tests and documents.

Describe any new or updated permissions being added

Nothing changed.

Description of how you validated changes

Updated tests and integ tests.

Checklist

BREAKING CHANGE: The class KinesisDataFirehosePutRecord has been renamed to FirehosePutRecord.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2025 05:25
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (73b9138) to head (6490546).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33758   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 13, 2025
@gracelu0 gracelu0 self-assigned this Mar 13, 2025
@Tietew
Copy link
Contributor Author

Tietew commented Mar 14, 2025

In other modules, integration classes/methods are generally named FirehoseXXXX instead of DataFirehoseXXXX.
So this class can be named FirehosePutRecord.

Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to just FirehosePutRecord? To be consistent with the scheduler docs: https://docs.aws.amazon.com/scheduler/latest/UserGuide/managing-targets-templated.html. Would be great if we could merge this in soon as well, since we are planning to graduate this module soon and this is a breaking change. Thanks!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2025
@mergify mergify bot dismissed gracelu0’s stale review March 18, 2025 01:23

Pull request has been modified.

@Tietew Tietew changed the title fix(scheduler-targets-alpha): rename KinesisDataFirehosePutRecord to DataFirehosePutRecord fix(scheduler-targets-alpha): rename KinesisDataFirehosePutRecord to FirehosePutRecord Mar 18, 2025
@Tietew
Copy link
Contributor Author

Tietew commented Mar 18, 2025

@gracelu0 Thank you for checking out.
I've renamed and updated the description.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 18, 2025
Copy link
Contributor

@gracelu0 gracelu0 Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this file is included here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a0cfdeb
a failure of git merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored the file from main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my bad in resolving merge conflict.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6490546
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Contributor

mergify bot commented Mar 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e6f5bc8 into aws:main Mar 18, 2025
23 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@Tietew Tietew deleted the sched-rename-datafirehose branch March 18, 2025 05:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants