Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glue-alpha: inconsistent workflow addconditionalTrigger casing #33751

Closed
1 task
apogeeoak opened this issue Mar 12, 2025 · 2 comments · Fixed by #33752
Closed
1 task

glue-alpha: inconsistent workflow addconditionalTrigger casing #33751

apogeeoak opened this issue Mar 12, 2025 · 2 comments · Fixed by #33752
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. p2

Comments

@apogeeoak
Copy link
Contributor

Describe the bug

The conditional workflow trigger (addconditionalTrigger) in version 2.182.0-alpha.0 of the aws-glue-alpha package contains inconsistent casing and should be updated to camel case.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

The conditional workflow trigger (addconditionalTrigger) is updated to camel case (addConditionalTrigger).

Current Behavior

The conditional workflow trigger is addconditionalTrigger, which contains inconsistent casing.

Reproduction Steps

N/A

Possible Solution

public addConditionalTrigger(id: string, options: ConditionalTriggerOptions): CfnTrigger {

Additional Information/Context

No response

CDK CLI Version

2.1003.0

Framework Version

2.182.0-alpha.0

Node.js Version

v20.18.3

OS

Ubuntu 22.04.5 LTS

Language

TypeScript

Language Version

TypeScript (~5.5.2)

Other information

No response
@apogeeoak apogeeoak added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 12, 2025
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Mar 12, 2025
@apogeeoak apogeeoak mentioned this issue Mar 12, 2025
Merged
1 task
@mergify mergify bot closed this as completed in #33752 Mar 12, 2025
@mergify mergify bot closed this as completed in 4886a3e Mar 12, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2025
hwum pushed a commit to hwum/aws-cdk that referenced this issue Mar 12, 2025
@apogeeoak @hwum
fix(glue-alpha): inconsistent workflow addconditionalTrigger casing (a…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ash2k Mikhail Mazurskiy
GPG key ID: FA7917C48932DD55
Expired
Verified
Learn about vigilant mode
5c53d59 
…ws#33752)

### Issue aws#33751

Closes aws#33751.

### Reason for this change

The conditional workflow trigger (`addconditionalTrigger`) in the `aws-glue-alpha` package contains inconsistent casing and should be updated to camel case.

### Description of changes

Updated the conditional workflow trigger (`addconditionalTrigger`) to camel case (`addConditionalTrigger`).

### Describe any new or updated permissions being added

None.

### Description of how you validated changes

Updated existing unit and integration tests, `aws-glue-alpha/test/integ.workflow.ts` and `aws-glue-alpha/test/workflow-triggers.test.ts`.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

BREAKING CHANGE: Updated casing of `workflow.addconditionalTrigger` to `workflow.addConditionalTrigger`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@pahud pahud added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(glue-alpha): inconsistent workflow addconditionalTrigger casing apogeeoak/aws-cdk
2 participants
@pahud @apogeeoak