fix(events-targets): add LogGroupTargetInput.fromObjectV2() method

[paulhcsun]

Reason for this change

The LogGroupTargetInput.fromObject() function returns a RuleTargetInput instead of a LogGroupTargetInput. It can therefore not be passed into the following field:

export interface LogGroupProps extends TargetBaseProps {
  // ...
  readonly logEvent?: LogGroupTargetInput;
}

Because the types don't match.

This is a bug that hasn't shown up in TypeScript before because according to TypeScript's structural typing rules, the types RuleTargetInput and LogGroupTargetInput are compatible, but according to Java's nominal typing rules they are not.

Description of changes

Deprecated LogGroupTargetInput.fromObject() and created LogGroupTargetInput.fromObjectV2() which returns the correct type of LogGroupTargetInput.

Description of how you validated changes

integ test

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (3de0818) to head (c1dc834).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33720   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         120      120           
  Lines        6933     6933           
  Branches     1169     1169           
=======================================
  Hits         5711     5711           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.37% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[5d]

Just a general question, following the conventional approach, have you considered making logEvent in LogGroupProps an interface and then having RuleTargetInput and LogGroupTargetInput implement that interface?

[gracelu0]

should this be LogGroupTargetInput.fromObjectV2()?

[paulhcsun]

Not necessarily but I don't think I need the duplicate V2 method in RuleTargetInput. I've updated this method in the latest commit.

[paulhcsun]

Thanks for review @5d. I'm not able to change the type of logEvent because it's getting passed into the bind method here:

aws-cdk/packages/aws-cdk-lib/aws-events-targets/lib/log-group.ts

Line 137 in d1a8cbe

input: this.props.event ?? this.props.logEvent,

and if the type is changed then that call won't work anymore.

[paulhcsun]

@merigyfio update

[paulhcsun]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c1dc834
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.