Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): jobQueueArn support JsonPath or JSONata #33670

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

phuhung273
Copy link
Contributor

Issue # (if applicable)

Closes #33580

Reason for this change

Incorrect IAM Policy for jobQueueArn when using JsonPath or JSONata

Description of changes

For JsonPath or JSONata jobQueueArn, IAM Policy use wildcard (*)

Describe any new or updated permissions being added

For JsonPath or JSONata jobQueueArn, IAM Policy use wildcard (*)

Description of how you validated changes

Unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…Nata
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Mar 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 2, 2025 04:09
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

phuhung273 and others added 2 commits March 13, 2025 00:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 12, 2025 17:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (fada917) to head (5b056a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33670   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2025
@scorbiere scorbiere self-assigned this Mar 17, 2025
FROM public.ecr.aws/lambda/python:3.6
FROM python:3.13-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the motivation for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure. The context is:

  • Back in the day, Lambda image behaviour was like executing a job: run and exit
  • Now, all Lambda image act like a backend server: keep running forever

When I tried the old Dockerfile, StateMachine execution never escape RUNNING state as ECS serve the image as a server.

So I decided to use the plain python image.

One weird thing is although there is a test using the changed Dockerfile, no snapshot change was detected. So I only ran my new test file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One weird thing is although there is a test using the changed Dockerfile, no snapshot change was detected. So I only ran my new test file.

After checking the implementation of DockerImageAsset I don't see any logic which use the docker file's content to compute asset's hash.

@scorbiere
Copy link
Contributor

Hi @phuhung273, thank you for this PR. I am good with the changes, and I can approve after you answer my comment.

@phuhung273 phuhung273 requested a review from scorbiere March 18, 2025 00:18
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 18, 2025 23:23

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b056a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1c09c8b into aws:main Mar 18, 2025
21 of 22 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2025
@phuhung273 phuhung273 deleted the batch-submit-job-iam branch March 19, 2025 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-stepfunction: Failed to create correct IAM role for step function
3 participants