-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): backfill missing enums for eks #33646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33646 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/** | ||
* [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
*/ | ||
CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* [PLACEHOLDER FOR: TO BE FILLED OUT] | |
*/ | |
CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
This may be an error in the tool, since this seems like the generic name for it rather than the type itself. Worth investigating before committing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a valid value according to CFN docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html
/** | ||
* [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
*/ | ||
CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a valid value according to CFN docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html
Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Description of changes
backfill missing enums for eks
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license