Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): backfill missing enums for eks #33646

Merged
merged 6 commits into from
Mar 13, 2025

Conversation

paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Feb 28, 2025

Description of changes

backfill missing enums for eks

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 23:22
@github-actions github-actions bot added the p2 label Feb 28, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (f9c533b) to head (acad985).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33646   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 110 to 113
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CAPACITY_BLOCK = 'CAPACITY_BLOCK',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CAPACITY_BLOCK = 'CAPACITY_BLOCK',

This may be an error in the tool, since this seems like the generic name for it rather than the type itself. Worth investigating before committing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid value according to CFN docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

@paulhcsun paulhcsun added the pr/do-not-merge This PR should not be merged at this time. label Mar 1, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Comment on lines 110 to 113
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CAPACITY_BLOCK = 'CAPACITY_BLOCK',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid value according to CFN docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

paulhcsun and others added 2 commits March 12, 2025 10:33
Co-authored-by: Leonardo Gama <51037424+Leo10Gama@users.noreply.github.com>
@paulhcsun paulhcsun marked this pull request as ready for review March 12, 2025 17:33
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2025
@paulhcsun paulhcsun added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/do-not-merge This PR should not be merged at this time. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Mar 12, 2025
@paulhcsun paulhcsun changed the title chore(eks): backfill missing enums for eks feat(eks): backfill missing enums for eks Mar 13, 2025
@paulhcsun paulhcsun added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Mar 13, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 13, 2025
@moelasmar moelasmar self-assigned this Mar 13, 2025
@moelasmar moelasmar added the pr-linter/exempt-test The PR linter will not require test changes label Mar 13, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 13, 2025 16:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: acad985
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f67a88b into aws:main Mar 13, 2025
20 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2025
@paulhcsun paulhcsun deleted the backfill-enums/eks branch March 14, 2025 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants