New issue

Jump to bottom

feat(ecs): backfill missing enums for ecs #33644

Merged

mergify merged 6 commits into aws:main from paulhcsun:backfill-enums/ecs

Mar 13, 2025

+4 −0

Contributor

paulhcsun commented Feb 28, 2025 •

edited

Loading

Description of changes

backfill missing enums for ecs

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


          chore(ecs): backfill missing enums for ecs

67497f5

aws-cdk-automation requested a review from a team

February 28, 2025 23:21

github-actions bot added the p2 label

mergify bot added the contribution/core label

codecov bot commented Feb 28, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (a7633a9) to head (2bcd711).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33644   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103

Flag	Coverage Δ
suite.unit	`82.38% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.38% <ø> (ø)`

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Leo10Gama reviewed

View reviewed changes

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated

Comment on lines 186 to 189

+                /**
+                 * [PLACEHOLDER FOR: TO BE FILLED OUT]
+                 */
+                NONE = 'NONE',

Member

Leo10Gama Mar 1, 2025

Suggested change

      
              /**
          
               * [PLACEHOLDER FOR: TO BE FILLED OUT]
          
               */
          
              NONE = 'NONE',

I think this is another enum value that may not be necessary given the situation, but I'm not 100% familiar with ECS. Worth investigating this instance before approving as well.

Contributor Author

paulhcsun Mar 12, 2025

This seems to be a valid value according to CFN docs here


          Update packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts

2662f1e

paulhcsun commented

View reviewed changes

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved


          Update packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts

9f8a6d8

paulhcsun marked this pull request as ready for review

March 12, 2025 17:28


          Merge branch 'main' into backfill-enums/ecs

c06ad15

aws-cdk-automation added the pr/needs-maintainer-review label

paulhcsun changed the title ~~chore(ecs): backfill missing enums for ecs~~ feat(ecs): backfill missing enums for ecs

paulhcsun added pr-linter/exempt-readme pr-linter/exempt-integ-test labels

aws-cdk-automation previously requested changes

View reviewed changes

Collaborator

aws-cdk-automation left a comment •

edited

Loading

(This review is outdated)

aws-cdk-automation removed the pr/needs-maintainer-review label

moelasmar reviewed

View reviewed changes

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated

+                /**
+                 * NONE
+                 */
+                NONE = 'NONE',

Contributor

moelasmar Mar 13, 2025

as per the documentation .. None is not allowed value.

moelasmar self-assigned this

paulhcsun commented

View reviewed changes

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved


          Update packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts

68225a6

paulhcsun added the pr-linter/exempt-test label

aws-cdk-automation dismissed their stale review

March 13, 2025 17:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

moelasmar approved these changes

View reviewed changes

Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).


          Merge branch 'main' into backfill-enums/ecs

2bcd711

Collaborator

aws-cdk-automation commented Mar 13, 2025

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 2bcd711
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Contributor

mergify bot commented Mar 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot merged commit 28c6a22 into aws:main

20 checks passed

github-actions bot commented Mar 13, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot locked as resolved and limited conversation to collaborators

paulhcsun deleted the backfill-enums/ecs branch

March 14, 2025 00:29

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core p2 pr-linter/exempt-integ-test pr-linter/exempt-readme pr-linter/exempt-test