Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sns): add signature version prop #29543

Merged
merged 7 commits into from Mar 29, 2024
Merged

feat(sns): add signature version prop #29543

merged 7 commits into from Mar 29, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 19, 2024

Closes #29539.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Mar 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2024 22:55
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Mar 19, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 19, 2024
lpizzinidev
lpizzinidev suggested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍
Left some suggestions for improvements

packages/aws-cdk-lib/aws-sns/lib/topic.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-sns/lib/topic.ts Outdated
@@ -173,6 +184,7 @@ export class Topic extends TopicBase {
public readonly topicName: string;
public readonly contentBasedDeduplication: boolean;
public readonly fifo: boolean;
public readonly signatureVersion?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the public variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the standard policy here? Prefer not to add it? This means take it out of topic-base.ts as well right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got rid of the public variable.

packages/aws-cdk-lib/aws-sns/lib/topic.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-sns/README.md Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 23, 2024
lpizzinidev
lpizzinidev approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👍
Left a comment for a minor adjustment, but overall looks good to me

packages/aws-cdk-lib/aws-sns/lib/topic.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 24, 2024
msambol and others added 2 commits March 24, 2024 13:56
@msambol @lpizzinidev
Update packages/aws-cdk-lib/aws-sns/lib/topic.ts
efbc315 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@msambol
fix formatting
72afb0a
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Closed
GavinZZ
GavinZZ approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding support for this property.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Mar 29, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 29, 2024

refresh

✅ Pull request refreshed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5c05483
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dffedca into aws:main Mar 29, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sns: Support for SignatureVersion
4 participants
@msambol @aws-cdk-automation @lpizzinidev @GavinZZ