feat(elasticloadbalancingv2): client keepalive for ALB #29504

badmintoncryer · 2024-03-15T05:25:41Z

Issue # (if applicable)

Reason for this change

ALB supports configuring client keepalive duration but AWS CDK cannot do that.

Description of changes

Add clientKeepAlive properties to ApplicationLoadBalancerProps.

      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });

Description of how you validated changes

I've added both integ and unit tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Looks good 👍
Left some suggestions for minor adjustments

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

badmintoncryer · 2024-03-15T23:13:15Z

@lpizzinidev Thank you for your review! I have adderssed your comments.

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

lpizzinidev

Thanks 👍

GavinZZ

LGTM, thanks for contributing

mergify · 2024-03-18T21:07:25Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-03-18T21:11:28Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-03-19T02:05:56Z

@GavinZZ Thank you for your review!
Mergify job seems to be failed. Could you please resolve it?

Pull request has been modified.

badmintoncryer · 2024-03-20T03:43:14Z

@GavinZZ I have resolved conflict. Could you please re-review this?

mergify · 2024-03-21T21:41:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-03-21T22:11:40Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-03-22T01:12:33Z

@GavinZZ Why does this Mergify job fail? Is there something wrong with how I create my PR?

GavinZZ · 2024-03-22T19:29:17Z

I'm unsure either, will monitor this PR and see the latest error if it happens again.

aws-cdk-automation · 2024-03-22T19:56:12Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 49c1768
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-03-22T19:56:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-03-23T01:16:33Z

@GavinZZ Thanks!

### Issue # (if applicable) Closes aws#29503. ### Reason for this change [ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that. ### Description of changes Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`. ```ts new elbv2.ApplicationLoadBalancer(stack, 'LB', { vpc, clientKeepAlive: Duration.seconds(250), }); ``` ### Description of how you validated changes I've added both integ and unit tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 15, 2024

aws-cdk-automation requested a review from a team March 15, 2024 05:25

aws-cdk-automation previously requested changes Mar 15, 2024

View reviewed changes

badmintoncryer marked this pull request as ready for review March 15, 2024 05:58

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024

lpizzinidev suggested changes Mar 15, 2024

View reviewed changes

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 15, 2024

badmintoncryer and others added 5 commits March 16, 2024 08:14

feat: support keep alive for ALB

34f7075

docs: update readme

2e9dd95

test: update integ test

f0efbea

Update application-load-balancer.ts

ceae5ba

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

feat: check millisec order clientKeepAlive

294a313

badmintoncryer force-pushed the keepAlve branch from 2a58a0f to 294a313 Compare March 15, 2024 23:14

Merge branch 'main' into keepAlve

5424cf5

lpizzinidev approved these changes Mar 16, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 16, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Weekly PR metrics report #29527

Closed

shikha372 self-assigned this Mar 18, 2024

GavinZZ previously approved these changes Mar 18, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 18, 2024

Merge branch 'main' into keepAlve

91ca90e

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 20, 2024

badmintoncryer added 2 commits March 21, 2024 16:13

Merge branch 'main' into keepAlve

eb2adb7

Merge branch 'main' into keepAlve

ec84ee9

shikha372 removed their assignment Mar 21, 2024

GavinZZ approved these changes Mar 21, 2024

View reviewed changes

Merge branch 'main' into keepAlve

23beb96

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 21, 2024

Merge branch 'main' into keepAlve

49c1768

GavinZZ self-assigned this Mar 22, 2024

mergify bot merged commit 9b79f94 into aws:main Mar 22, 2024
9 checks passed

badmintoncryer deleted the keepAlve branch March 25, 2024 05:41

github-actions bot mentioned this pull request Apr 1, 2024

Monthly PR metrics report #29668

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elasticloadbalancingv2): client keepalive for ALB #29504

feat(elasticloadbalancingv2): client keepalive for ALB #29504

badmintoncryer commented Mar 15, 2024 •

edited

aws-cdk-automation left a comment

lpizzinidev left a comment

badmintoncryer commented Mar 15, 2024

lpizzinidev left a comment

GavinZZ left a comment

mergify bot commented Mar 18, 2024

mergify bot commented Mar 18, 2024

badmintoncryer commented Mar 19, 2024

badmintoncryer commented Mar 20, 2024

mergify bot commented Mar 21, 2024

mergify bot commented Mar 21, 2024

badmintoncryer commented Mar 22, 2024

GavinZZ commented Mar 22, 2024

aws-cdk-automation commented Mar 22, 2024

mergify bot commented Mar 22, 2024

badmintoncryer commented Mar 23, 2024

feat(elasticloadbalancingv2): client keepalive for ALB #29504

feat(elasticloadbalancingv2): client keepalive for ALB #29504

Conversation

badmintoncryer commented Mar 15, 2024 • edited

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

badmintoncryer commented Mar 15, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

GavinZZ left a comment

Choose a reason for hiding this comment

mergify bot commented Mar 18, 2024

mergify bot commented Mar 18, 2024

badmintoncryer commented Mar 19, 2024

badmintoncryer commented Mar 20, 2024

mergify bot commented Mar 21, 2024

mergify bot commented Mar 21, 2024

badmintoncryer commented Mar 22, 2024

GavinZZ commented Mar 22, 2024

aws-cdk-automation commented Mar 22, 2024

AWS CodeBuild CI Report

mergify bot commented Mar 22, 2024

badmintoncryer commented Mar 23, 2024

badmintoncryer commented Mar 15, 2024 •

edited