Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): unrecognized statistic warning when using percentileRank statistic in Stats helper #29498

Merged
merged 3 commits into from Mar 15, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Mar 14, 2024

Issue # (if applicable)

Closes #29465.

Reason for this change

There shouldn't be a warning when Stats.percentileRank

Description of changes

Add a new parser for percentileRank statistic

Description of how you validated changes

unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Mar 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 14, 2024 23:57
@github-actions github-actions bot added the p1 label Mar 14, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 14, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xazhao xazhao added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 14, 2024
@xazhao
Copy link
Contributor Author

xazhao commented Mar 15, 2024

The PR just removes the warning so no integration test is required.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 15, 2024 00:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 15, 2024
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 52e5b1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f2ad980 into aws:main Mar 15, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudwatch: Unrecognized statistic warning when using Stats helper.
3 participants