fix(cli): cdk watch for Lambdas with Advanced Logging Controls do not stream logs to the terminal

[onhate]

Issue

Closes #29448

Reason for this change

After the release of Advanced Logging Controls for Lambda (see https://aws.amazon.com/blogs/compute/introducing-advanced-logging-controls-for-aws-lambda-functions/) I've decided to move all the logs of my multi-stack deployment to a single unified Log Group per deployed tenant.

It goes likes this:

The main stack creates the LogGroup like /aws/lambda/{tenant};
The secondary stacks refers to the LogGroup using LogGroup.fromLogGroupArn(...);
Then I discovered that running cdk watch on the main stack I can see the cloudwatch logs on my terminal while on the secondary stacks it does not;

I found at that the cloudwatch log group resolver for the logs basically just assumes the log group is /aws/lambda/{physicalId}

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/lib/api/logs/find-cloudwatch-logs.ts#L114

Description of changes

Use the Template JSON to resolve the LoggingConfig.LogGroupName of the Lambda Function;

Description of how you validated changes

I've replace the node_modules/aws-cdk of my project with the one built from this PR and I was able to see the logs of my lambda that has custom LogConfig, as you can see it is grabbing the logs of /aws/lambda/dev cloudwatch logs

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[onhate]

Exemption Request

as this change is only on the cdk watch logic I could not find a way to write a integration test for it.

[scanlonp]

Hey @onhate, thanks for the quick update. I ran this through the pipeline, but it is failing due to another change we have made. Once I fix the pipeline, I'll throw this in there again, and if it passes, approve it!

[scanlonp]

Also, can you tweak your PR title so that it describes the bug rather than the fix? Along the lines of "Referenced lambda streams not used for cdk watch", but more eloquent.

[onhate]

@scanlonp do you have an update on this matter? thanks.

[scanlonp]

@onhate, I should be good to submit it later today. I will keep you updated on the status of the run.

[scanlonp]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[scanlonp]

Passing the test pipeline. Thanks for your patience!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f941cde
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[onhate]

Passing the test pipeline. Thanks for your patience!

thanks @scanlonp ! :)