feat(autoscaling): support custom termination policy with lambda #29340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
paulhcsun
changed the title
paulhcsun
changed the title
godwingrs22
force-pushed
the
godwingrs22/custometerminalpolicy
branch
from
bc01697
to
4ebbe8c
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
GavinZZ
reviewed
Mar 4, 2024
GavinZZ
reviewed
Mar 4, 2024
godwingrs22
force-pushed
the
godwingrs22/custometerminalpolicy
branch
from
f434bee
to
4458a4f
Compare
godwingrs22
force-pushed
the
godwingrs22/custometerminalpolicy
branch
from
4458a4f
to
8c93a48
Compare
GavinZZ
approved these changes
Mar 4, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #19750.
Reason for this change
Amazon EC2 autoscaling supports custom termination policy using lambda to terminate instances, but it is not supported yet by the
aws-autoscalingpackage.Description of changes
This code change adds an enum
TerminationPolicy.CUSTOM_LAMBDA_FUNCTIONand an optionalterminationPolicyCustomLambdaFunctionArnproperty to pass the lambda arn.The change involves the logic to check If there are multiple termination policies specified since lamba termination policy has to be first in order.
Description of how you validated changes
Added unit tests and integration test.
Created a simple CDK application with the updated constructs and verified that it synthesized and deployed correctly.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license