Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs-patterns): allow custom ephemeral storage for ECS Fargate services #29275

Merged
merged 19 commits into from Mar 1, 2024

Conversation

daixi98
Copy link
Contributor

@daixi98 daixi98 commented Feb 27, 2024

Issue # (if applicable)

Closes #18105.

Reason for this change

In April 2021, Fargate added support for requesting additional ephemeral storage.

Support for this feature has been added to the aws-ecs package, but is still not supported by the aws-ecs-patterns package.

Description of changes

This code change adds an optional field ephemeralStorageGiB in packages/aws-cdk-lib/aws-ecs-patterns/lib/base/fargate-service-base.ts, after other fields like cpu and memoryLimitMiB.

Description of how you validated changes

Added unit tests and new integration tests.
Created a simple CDK application with the new constructs, and verified that it synthesized and deployed correctly.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 27, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 27, 2024 04:15
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Feb 27, 2024
@daixi98 daixi98 closed this Feb 27, 2024
@daixi98 daixi98 reopened this Feb 27, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@daixi98 daixi98 marked this pull request as draft February 27, 2024 05:57
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 27, 2024 06:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@daixi98 daixi98 marked this pull request as ready for review February 27, 2024 07:29
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one question

@daixi98 daixi98 requested a review from aaythapa March 1, 2024 03:25
Copy link
Contributor

mergify bot commented Mar 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5e4d58c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9156b13 into aws:main Mar 1, 2024
11 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-ecs-patterns): add support for Fargate ephemeral storage
3 participants