Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): escaped curly braces result in error during state machine execution #29267

Merged
merged 1 commit into from Feb 26, 2024

Conversation

clareliguori
Copy link
Member

@clareliguori clareliguori commented Feb 26, 2024

Issue # (if applicable)

Closes #29261

Reason for this change

Enable proper escaping of curly braces in Step Functions intrinsic functions. The user needs to be able to explicitly escape curly braces to distinguish them from curly braces used for intrinsic function arguments (\{\} vs {}. Currently, the escaping logic double-escapes an already-escaped curly brace. The state machine successfully deploys, but then fails to execute.

Description of changes

When a backslash immediately precedes a curly brace, it will not be escaped.

Description of how you validated changes

Added a case to an existing integration test, and updated the integ test to execute the deployed state machine to check for runtime errors.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 labels Feb 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 26, 2024 19:00
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Feb 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@clareliguori clareliguori changed the title fix(stepfunctions): Escaped curly braces result in error during state machine execution fix(stepfunctions): escaped curly braces result in error during state machine execution Feb 26, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 26, 2024 19:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2cad7b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 26, 2024
Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a21e429 into aws:main Feb 26, 2024
29 of 30 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 26, 2024
@clareliguori clareliguori deleted the curly-brace-escape branch February 27, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions: Escaping curly braces not supported in intrinsic functions
3 participants