Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): autoscalingGroup attribute does not exist on ImportedCluster #29244

Merged
merged 3 commits into from Feb 28, 2024
Merged

fix(ecs): autoscalingGroup attribute does not exist on ImportedCluster #29244

merged 3 commits into from Feb 28, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Feb 24, 2024 •
edited by colifran

This PR adds an autoscalingGroup attribute to ImportedCluster. This attribute is set using the autoscalingGroup property from ClusterAttributes in the constructor of ImportedCluster.

Closes #29241.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Feb 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 24, 2024 20:16
@github-actions github-actions bot added bug This issue is a bug. p2 labels Feb 24, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol msambol changed the title fix(ecs): import asgs with fromClusterAttributes fix(ecs): import autoscaling group with fromClusterAttributes Feb 24, 2024
@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 24, 2024
lpizzinidev
lpizzinidev suggested changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍
It would be nice to add integration test coverage if possible, similar to what we have for EKS.
Also, the title should be updated to describe the bug (not the solution).

packages/aws-cdk-lib/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 25, 2024
@msambol msambol changed the title fix(ecs): import autoscaling group with fromClusterAttributes fix(ecs): can't import autoscaling group via fromClusterAttributes Feb 25, 2024
@msambol
Copy link
Contributor Author

msambol commented Feb 25, 2024

@lpizzinidev Added integration test 👍🏼

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 25, 2024 21:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev
lpizzinidev approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 26, 2024
@colifran colifran changed the title fix(ecs): can't import autoscaling group via fromClusterAttributes fix(ecs): autoscalingGroup attribute does not exist on ImportedCluster Feb 26, 2024
colifran
colifran approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Feb 26, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024

refresh

✅ Pull request refreshed

@tim-finnigan tim-finnigan mentioned this pull request Feb 26, 2024
Closed
@msambol
Copy link
Contributor Author

msambol commented Feb 26, 2024

@tim-finnigan Can you queue this one up? I think it's stuck.

@aws-cdk-automation aws-cdk-automation removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Feb 27, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 27, 2024

refresh

✅ Pull request refreshed

@msambol
Copy link
Contributor Author

msambol commented Feb 28, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

refresh

✅ Pull request refreshed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 008f585
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 98b9bf2 into aws:main Feb 28, 2024
10 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol msambol deleted the 29241 branch February 28, 2024 19:24
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@colifran colifran colifran approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ecs: Cluster.fromClusterAttributes does not properly set autoScalingGroup
4 participants
@msambol @aws-cdk-automation @lpizzinidev @colifran